Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCDL-251 Taxonomy Alignment - HCP Terraform #419

Merged
merged 31 commits into from
May 6, 2024
Merged

VCDL-251 Taxonomy Alignment - HCP Terraform #419

merged 31 commits into from
May 6, 2024

Conversation

jennamwong
Copy link
Contributor

DO NOT MERGE!!!!!!!!!

Changing TFC terminology to HCP Terraform. Adding product feature alignment.
Do not merge until April 22, 2024!

@jennamwong jennamwong requested a review from a team as a code owner March 28, 2024 16:24
jennamwong and others added 4 commits April 5, 2024 16:02
Co-authored-by: Syed Quadri <[email protected]>
Copy link
Contributor

@syedQuadri7 syedQuadri7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed some references, can merge once updated

@thomashashi thomashashi marked this pull request as draft April 24, 2024 14:57
@thomashashi
Copy link
Contributor

Marking this as draft because we'll need to figure out a communications plan before we change the track names/slugs; per discussion with Jenna on 24 April.

@@ -7,7 +7,7 @@
<html>

<head>
<title>Introduction to Terraform OSS on Azure</title>
<title>Introduction to Terraform Community Edition on AWS</title>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be AWS or Azure? I see that the path changed from slides/azure/ to slides/aws

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the file paths are changing. The path is for AWS and that's what the current state of the file shows, so leaving as is.

Copy link
Contributor

@syedQuadri7 syedQuadri7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add copyright to track.yml files. Left other comments to address before merging.

# Copyright (c) HashiCorp, Inc.
# SPDX-License-Identifier: MPL-2.0

Copy link
Contributor

@syedQuadri7 syedQuadri7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syedQuadri7 syedQuadri7 marked this pull request as ready for review May 2, 2024 18:45
@jennamwong jennamwong merged commit 6911ba1 into main May 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants